linux-kernel - Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140206002512.GA654@earth.universe>
Date:	Thu, 6 Feb 2014 01:25:12 +0100
From:	Sebastian Reichel <sre@...ian.org>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Tony Lindgren <tony@...mide.com>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, freemangordon@....bg
Subject: Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900

On Wed, Feb 05, 2014 at 09:42:30PM +0100, Pali Rohár wrote:
> 2014-02-05 Sebastian Reichel <sre@...ian.org>:
> > Hi,
> >
> > On Wed, Feb 05, 2014 at 05:38:54PM +0100, Pali Rohár wrote:
> >> > I assumed, that the workaround is not needed for this device type.
> >>
> >> That rx51 secure call must not be called on non secure devices (e.g.
> >> qemu), because it cause kernel crash. So I thought that kernel should
> >> write something like secure call is disabled on that device types.
> >> Kernel code for errata 430973 will update ibe bit for non secure
> >> devices.
> >
> > Do you see any advantage in having that message?
> >
> 
> Consistency. Print message 1) only if secure rx51 smc instruction is
> called or 2) print message always (also if smc is not called). With
> that patch message is printed (enabled/disabled) only if device is
> rx51 and device type is HS.
> 
> For information it is also good to know that in qemu that special
> secure smc instruction was not called.

Assuming I do not know about this errata/workaround and have some
problems with crashing binaries I may have a look at the kernel
warnings. Without the additional message I won't get any hint about
the errata/workaround at all.

On the other hand there is no such information gain on qemu. It just
tells the user, that some workaround, which is not needed, has not
been activated.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)