linux-kernel - Re: [PATCH 06/12] backlight: ili922x: Remove unnecessary OOM messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Feb 2014 10:15:16 +0100
From:	Stefano Babic <sbabic@...x.de>
To:	Jingoo Han <jg1.han@...sung.com>,
	'Andrew Morton' <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, 'Stefano Babic' <sbabic@...x.de>,
	'Anatolij Gustschin' <agust@...x.de>
Subject: Re: [PATCH 06/12] backlight: ili922x: Remove unnecessary OOM messages

Hi Jingoo,

On 06/02/2014 09:21, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/video/backlight/ili922x.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index 73464e4..ea67fe1 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -482,10 +482,8 @@ static int ili922x_probe(struct spi_device *spi)
>  	u16 reg = 0;
>  
>  	ili = devm_kzalloc(&spi->dev, sizeof(*ili), GFP_KERNEL);
> -	if (!ili) {
> -		dev_err(&spi->dev, "cannot alloc priv data\n");
> +	if (!ili)
>  		return -ENOMEM;
> -	}
>  
>  	ili->spi = spi;
>  	spi_set_drvdata(spi, ili);
> 

Acked-by: Stefano Babic <sbabic@...x.de>

Thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@...x.de
=====================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/