linux-kernel - Re: [PATCH] pinctrl: do not init debugfs entries for unimplemented functionalities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdatZQeh7mzfbtcrj+ksMP3uyQbMkB66R=V0KOUpY3CJRA@mail.gmail.com>
Date:	Thu, 6 Feb 2014 13:48:12 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Florian Vaussard <florian.vaussard@...l.ch>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: do not init debugfs entries for unimplemented functionalities

On Wed, Feb 5, 2014 at 7:51 AM, Florian Vaussard
<florian.vaussard@...l.ch> wrote:

> Commit c420619 "pinctrl: pinconf: remove checks on ops->pin_config_get"
> removed the check on (ops != NULL) when performing pinconf_pins_show() or
> pinconf_groups_show(). As these entries are always enabled, even if
> pinconf is not supported, reading will result in an oops due to NULL
> ops.
>
> Instead of checking for ops, remove the corresponding debugfs entries if
> pinconf and/or pinmux are not implemented.
>
> Tested on OMAP3 (pinctrl-single).
>
> Signed-off-by: Florian Vaussard <florian.vaussard@...l.ch>

Oh that was an elegant fix, thanks!
Patch applied for fixes, tagged for stable.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/