linux-kernel - Re: [PATCH 0/4] clk: mvebu: fix clk init order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140206180852.GK8533@titan.lakedaemon.net>
Date:	Thu, 6 Feb 2014 13:08:52 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Andrew Lunn <andrew@...n.ch>,
	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH 0/4] clk: mvebu: fix clk init order

On Thu, Feb 06, 2014 at 02:08:39PM -0300, Ezequiel Garcia wrote:
> On Wed, Feb 05, 2014 at 01:34:57PM -0500, Jason Cooper wrote:
> > On Sat, Jan 25, 2014 at 07:19:06PM +0100, Sebastian Hesselbarth wrote:
> > > This patch set fixes clk init order that went upside-down with
> > > v3.14. I haven't really investigated what caused this, but I assume
> > > it is related with DT node reordering by addresses.
> > > 
> > > Anyway, with v3.14 for MVEBU SoCs, the clock gating driver gets
> > > registered before core clocks driver. Unfortunately, we cannot
> > > return -EPROBE_DEFER in drivers initialized by clk_of_init. As the
> > > init order for our drivers is always core clocks before clock gating,
> > > we maintain init order ourselves by hooking CLK_OF_DECLARE to one
> > > init function that will register core clocks before clock gating
> > > driver.
> > > 
> > > This patch is based on pre-v3.14-rc1 mainline and should go in as
> > > fixes for it. As we now send MVEBU clk pull-requests to Mike directly,
> > > I suggest Jason picks it up as a topic branch.
> > > 
> > > The patches have been boot tested on Dove and compile-tested only
> > > for Kirkwood, Armada 370 and XP.
> > > 
> > > Sebastian Hesselbarth (4):
> > >   clk: mvebu: armada-370: maintain clock init order
> > >   clk: mvebu: armada-xp: maintain clock init order
> > >   clk: mvebu: dove: maintain clock init order
> > >   clk: mvebu: kirkwood: maintain clock init order
> > > 
> > >  drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
> > >  drivers/clk/mvebu/armada-xp.c  | 20 +++++++++-----------
> > >  drivers/clk/mvebu/dove.c       | 19 +++++++++----------
> > >  drivers/clk/mvebu/kirkwood.c   | 34 ++++++++++++++++------------------
> > >  4 files changed, 44 insertions(+), 50 deletions(-)
> > 
> > Whole series applied to mvebu/clk-fixes.
> > 
> 
> FWIW, Tested-by: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
> 
> Observed "division by zero" get fixed by this, on A370 Mirabox, Kirkwood
> Topkick and Dove Cubox.

Added for patches 1, 3, and 4 (all but armada-xp.c)  Thanks for testing.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/