lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Thu, 6 Feb 2014 13:13:08 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Pekka Enberg <penberg@...nel.org>
cc:	Michael Dalton <mwdalton@...gle.com>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: [patch kvmtool] x86, kvmtool: Fix build when KVM_TOOL_TEST_ENABLE
 is set

Commit ab7db91705e9 ("virtio-net: auto-tune mergeable rx buffer size for 
improved performance") requires CONFIG_AVERAGE to be set, which is 
selected by CONFIG_VIRTIO_NET, otherwise the build fails:

drivers/built-in.o: In function `virtnet_poll':
virtio_net.c:(.text+0x11d51f): undefined reference to `ewma_add'
drivers/built-in.o: In function `virtnet_probe':
virtio_net.c:(.text+0x11e668): undefined reference to `ewma_init'

CONFIG_KVM_TOOL_TEST_ENABLE selects CONFIG_VIRTIO_NET but not 
CONFIG_AVERAGE so the build breaks when enabling it.

Select CONFIG_AVERAGE for CONFIG_KVMTOOL_TEST_ENABLE.

Signed-off-by: David Rientjes <rientjes@...gle.com>
---
 Also affects tip/master.

 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -615,6 +615,7 @@ config KVMTOOL_TEST_ENABLE
 	select VIRTIO_BLK
 	select VIRTIO_CONSOLE
 	select VIRTIO_NET
+	select AVERAGE
 	select 9P_FS
 	select NET_9P
 	select NET_9P_VIRTIO
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists