linux-kernel - Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ7t2Z0agZdDZ_OQZPtXWXoi5NMTcOOZz04q6wEVNy0rxn4AA@mail.gmail.com>
Date:	Thu, 6 Feb 2014 22:21:37 +0100
From:	Carlo Caione <carlo.caione@...il.com>
To:	tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Hans De Goede <hdegoede@...hat.com>, emilio@...pez.com.ar,
	linux-sunxi@...glegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack
 level-triggered interrupts before unmasking

On Thu, Feb 6, 2014 at 10:14 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Thu, 6 Feb 2014, Carlo Caione wrote:
>
>> Several irqchip drivers require the level-triggered interrupt to be
>> acked before unmasking to avoid that a second interrupt is immediately
>> triggered. This small patch introduces a new irqchip flags that is used
>> to ack the IRQ line before it is unmasked.
>
> And why are you not doing this in the unmask function of the affected
> chip in the first place?

Because this is a common behavior of several irqchips (sunxi NMI
controller,  exynos, etc...) so I think it should be useful to have it
in the core instead of replicating the same code structure in all the
irqchip drivers.

Thanks,

-- 
Carlo Caione
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/