linux-kernel - RE: [PATCH 3.13] mei: mei_hbm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B1AF69D63@HASMSX106.ger.corp.intel.com>
Date:	Fri, 7 Feb 2014 00:26:59 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Paul Bolle <pebolle@...cali.nl>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"Usyskin, Alexander" <alexander.usyskin@...el.com>
Subject: RE: [PATCH 3.13] mei: mei_hbm_dispatch() returns void

> 
> Building hbm.o for v3.13.2 triggers a GCC warning:
>     drivers/misc/mei/hbm.c: In function 'mei_hbm_dispatch':
>     drivers/misc/mei/hbm.c:596:3: warning: 'return' with a value, in function
> returning void [enabled by default]
>        return 0;
>        ^
> 
> GCC is correct, obviously. So let's return void instead of zero here.

The patch was based on top of this one  http://www.spinics.net/lists/stable/msg31386.html , which was too big for stable,
So  your fix is correct here.
ACK.