linux-kernel - Re: [PATCH] vt: initialize con_driver->node in con

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140207164500.GB32655@kroah.com>
Date:	Fri, 7 Feb 2014 08:45:00 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Wang YanQing <udknight@...il.com>, jslaby@...e.cz,
	airlied@...hat.com, akpm@...ux-foundation.org, kilobyte@...band.pl,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vt: initialize con_driver->node in con_init

On Mon, Dec 30, 2013 at 11:11:02AM +0800, Wang YanQing wrote:
> Commit 6db4063c5b72b46e9793b0f141a7a3984ac6facf
> ("[PATCH] VT binding: Add sysfs control to the VT layer")
> add node item into struct con_driver.

That commit was almost a decade ago, is this patch really needed?

> This patch initialize con_driver->node in con_init.

You are saying what it does, not _why_ it is needed or why this change
is happening.

Please rewrite this with more information because as-is, I have no idea
why I should accept this patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/