linux-kernel - Re: [PATCH 2/2] block: Mark function as static in blk-throttle.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140208183804.GC14801@leaf>
Date:	Sat, 8 Feb 2014 10:38:04 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 2/2] block: Mark function as static in blk-throttle.c

On Sat, Feb 08, 2014 at 09:56:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in blk-throttle.c because it is not used
> outside this file.
> 
> This eliminates the following warning in blk-throttle.c:
> block/blk-throttle.c:1261:6: warning: no previous prototype for ‘blk_throtl_dispatch_work_fn’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  block/blk-throttle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 1474c3a..0face33 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -1258,7 +1258,7 @@ out_unlock:
>   * of throtl_data->service_queue.  Those bio's are ready and issued by this
>   * function.
>   */
> -void blk_throtl_dispatch_work_fn(struct work_struct *work)
> +static void blk_throtl_dispatch_work_fn(struct work_struct *work)
>  {
>  	struct throtl_data *td = container_of(work, struct throtl_data,
>  					      dispatch_work);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/