linux-kernel - Re: [PATCH 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140208201120.GG20885@leaf>
Date:	Sat, 8 Feb 2014 12:11:21 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Gao feng <gaofeng@...fujitsu.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Steffen Hurrle <steffen@...rle.net>,
	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
	linux-decnet-user@...ts.sourceforge.net
Subject: Re: [PATCH 07/13] net: Move prototype declaration to header file
 include/net/dn.h from net/decnet/af_decnet.c

On Sun, Feb 09, 2014 at 01:29:55AM +0530, Rashika Kheria wrote:
> Move prototype declaration of functions to header file include/net/dn.h
> from net/decnet/af_decnet.c because they are used by more than one file.
> 
> This eliminates the following warning in net/decnet/af_decnet.c:
> net/decnet/sysctl_net_decnet.c:354:6: warning: no previous prototype for ‘dn_register_sysctl’ [-Wmissing-prototypes]
> net/decnet/sysctl_net_decnet.c:359:6: warning: no previous prototype for ‘dn_unregister_sysctl’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  include/net/dn.h       |    2 ++
>  net/decnet/af_decnet.c |    3 ---
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/include/net/dn.h b/include/net/dn.h
> index ccc1558..913b73d 100644
> --- a/include/net/dn.h
> +++ b/include/net/dn.h
> @@ -200,6 +200,8 @@ static inline void dn_sk_ports_copy(struct flowidn *fld, struct dn_scp *scp)
>  }
>  
>  unsigned int dn_mss_from_pmtu(struct net_device *dev, int mtu);
> +void dn_register_sysctl(void);
> +void dn_unregister_sysctl(void);
>  
>  #define DN_MENUVER_ACC 0x01
>  #define DN_MENUVER_USR 0x02
> diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
> index 24d9193..4c04848 100644
> --- a/net/decnet/af_decnet.c
> +++ b/net/decnet/af_decnet.c
> @@ -2351,9 +2351,6 @@ static const struct proto_ops dn_proto_ops = {
>  	.sendpage =	sock_no_sendpage,
>  };
>  
> -void dn_register_sysctl(void);
> -void dn_unregister_sysctl(void);
> -
>  MODULE_DESCRIPTION("The Linux DECnet Network Protocol");
>  MODULE_AUTHOR("Linux DECnet Project Team");
>  MODULE_LICENSE("GPL");
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/