linux-kernel - Re: [PATCH 04/13] net: Mark functions as static in core/dev.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140208211850.GB1205@redhat.com>
Date:	Sat, 8 Feb 2014 22:18:50 +0100
From:	Veaceslav Falico <vfalico@...hat.com>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, josh@...htriplett.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Pravin B Shelar <pshelar@...ira.com>,
	Cong Wang <amwang@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 04/13] net: Mark functions as static in core/dev.c

On Sun, Feb 09, 2014 at 01:23:45AM +0530, Rashika Kheria wrote:
>Mark functions as static in core/dev.c because they are not used outside
>this file.
>
>This eliminates the following warning in core/dev.c:
>net/core/dev.c:2806:5: warning: no previous prototype for ‘__dev_queue_xmit’ [-Wmissing-prototypes]
>net/core/dev.c:4640:5: warning: no previous prototype for ‘netdev_adjacent_sysfs_add’ [-Wmissing-prototypes]
>net/core/dev.c:4650:6: warning: no previous prototype for ‘netdev_adjacent_sysfs_del’ [-Wmissing-prototypes]
>
>Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Veaceslav Falico <vfalico@...hat.com>

>---
> net/core/dev.c |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 3721db7..4ad1b78 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -2803,7 +2803,7 @@ EXPORT_SYMBOL(dev_loopback_xmit);
>  *      the BH enable code must have IRQs enabled so that it will not deadlock.
>  *          --BLG
>  */
>-int __dev_queue_xmit(struct sk_buff *skb, void *accel_priv)
>+static int __dev_queue_xmit(struct sk_buff *skb, void *accel_priv)
> {
> 	struct net_device *dev = skb->dev;
> 	struct netdev_queue *txq;
>@@ -4637,7 +4637,7 @@ struct net_device *netdev_master_upper_dev_get_rcu(struct net_device *dev)
> }
> EXPORT_SYMBOL(netdev_master_upper_dev_get_rcu);
>
>-int netdev_adjacent_sysfs_add(struct net_device *dev,
>+static int netdev_adjacent_sysfs_add(struct net_device *dev,
> 			      struct net_device *adj_dev,
> 			      struct list_head *dev_list)
> {
>@@ -4647,7 +4647,7 @@ int netdev_adjacent_sysfs_add(struct net_device *dev,
> 	return sysfs_create_link(&(dev->dev.kobj), &(adj_dev->dev.kobj),
> 				 linkname);
> }
>-void netdev_adjacent_sysfs_del(struct net_device *dev,
>+static void netdev_adjacent_sysfs_del(struct net_device *dev,
> 			       char *name,
> 			       struct list_head *dev_list)
> {
>-- 
>1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/