linux-kernel - Re: [PATCH] [media] si4713: Remove "select SI4713"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52F79C37.5030000@xs4all.nl>
Date:	Sun, 09 Feb 2014 16:18:15 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] si4713: Remove "select SI4713"

On 02/09/2014 03:56 PM, Paul Bolle wrote:
> Commits 7391232e1215 ("[media] si4713: Reorganized drivers/media/radio
> directory") and b874b39fcd2f ("[media] si4713: Added the USB driver for
> Si4713") both added a "select SI4713". But there's no Kconfig symbol
> SI4713, so these selects are nops. It's not clear why they were added
> but it's safe to remove them anyway.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select
should be I2C_SI4713. If you can post a patch fixing that, then I'll pick
it up for 3.14.

With the addition of the USB si4713 driver things moved around and were
renamed, and these selects were missed.

Regards,

	Hans

> ---
> Untested!
> 
>  drivers/media/radio/si4713/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig
> index a7c3ba8..ed51ed0 100644
> --- a/drivers/media/radio/si4713/Kconfig
> +++ b/drivers/media/radio/si4713/Kconfig
> @@ -1,7 +1,6 @@
>  config USB_SI4713
>  	tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB"
>  	depends on USB && RADIO_SI4713
> -	select SI4713
>  	---help---
>  	  This is a driver for USB devices with the Silicon Labs SI4713
>  	  chip. Currently these devices are known to work.
> @@ -16,7 +15,6 @@ config USB_SI4713
>  config PLATFORM_SI4713
>  	tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C"
>  	depends on I2C && RADIO_SI4713
> -	select SI4713
>  	---help---
>  	  This is a driver for I2C devices with the Silicon Labs SI4713
>  	  chip.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/