linux-kernel - Re: [PATCH 19/28] Remove SI4713

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Feb 2014 20:13:39 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Richard Weinberger <richard@....at>
CC:	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	"open list:MEDIA INPUT INFRA..." <linux-media@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	Paul Bolle <pebolle@...cali.nl>
Subject: Re: [PATCH 19/28] Remove SI4713

On 02/09/2014 07:47 PM, Richard Weinberger wrote:
> The symbol is an orphan, get rid of it.

NACK.

It's not an orphan, it's a typo. It should be I2C_SI4713.

Paul, Richard, let me handle this. I'll make a patch for this tomorrow (I believe
there was a report about a missing I2C dependency as well) and make sure it ends
up in a pull request for 3.14.

Regards,

	Hans

> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  drivers/media/radio/si4713/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig
> index a7c3ba8..ed51ed0 100644
> --- a/drivers/media/radio/si4713/Kconfig
> +++ b/drivers/media/radio/si4713/Kconfig
> @@ -1,7 +1,6 @@
>  config USB_SI4713
>  	tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB"
>  	depends on USB && RADIO_SI4713
> -	select SI4713
>  	---help---
>  	  This is a driver for USB devices with the Silicon Labs SI4713
>  	  chip. Currently these devices are known to work.
> @@ -16,7 +15,6 @@ config USB_SI4713
>  config PLATFORM_SI4713
>  	tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C"
>  	depends on I2C && RADIO_SI4713
> -	select SI4713
>  	---help---
>  	  This is a driver for I2C devices with the Silicon Labs SI4713
>  	  chip.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/