linux-kernel - Re: [PATCH] sched/wait: suppress sparse 'variable shadowing' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140209124442.GA21967@gmail.com>
Date:	Sun, 9 Feb 2014 13:44:42 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Johannes Berg <johannes@...solutions.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] sched/wait: suppress sparse 'variable shadowing' warning


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 6 Feb 2014 17:45:58 +0100
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Thu, Feb 06, 2014 at 05:28:41PM +0100, Johannes Berg wrote:
> > > From: Johannes Berg <johannes.berg@...el.com>
> > > 
> > > This warning seems to show up a lot now, since ___wait_event()
> > > is (indirectly) used inside wait_event_timeout(), which also
> > > has a variable called __ret. Rename the one in ___wait_event()
> > > to ___ret (another leading underscore) to suppress the warning.
> > > 
> > > Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> > 
> > Thanks!
> 
> Tag, you're it!
> 
> Now you need to submit a patch to fix one sparse warning this week ;-)
> 
> Yeah, yeah, I know. Like you have time.
> 
> This could be a cool drinking game. Every time you fix someone else's
> sparse error, they have to drink a pint :-)

... which game would result in a heightened mood amongst developers 
and even more Sparse errors, resulting in more fixes from PeterZ and 
more pints downed, creating a nice feedback loop. Sounds like fun for 
everyone, except Peter? ;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/