linux-kernel - Re: [PATCH 0/3] Fix perf build breakages in 3.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1392067925.12555.19.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 10 Feb 2014 21:32:05 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH 0/3] Fix perf build breakages in 3.13

On Mon, 2014-02-10 at 14:52 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 06, 2014 at 02:13:15PM +0000, Ben Hutchings escreveu:
> > On Thu, 2014-02-06 at 10:48 -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Feb 06, 2014 at 12:59:21AM +0000, Ben Hutchings escreveu:
> > > > perf no longer compiles on powerpc and sparc due to changes in the trace
> > > > sub-command.  This series fixes those compile errors; I compile-tested
> > > > in Debian sid on armhf, i386, powerpc and sparc.
> > > > 
> > > > I would much prefer not to revert the tty ioctl decoding but I think
> > > > it's going to take a much more sophisticated approach to do it right
> > > > across all supported architectures.
> > > 
> > > Second thought on the revert one:
> > > 
> > > Do you have a problem of switching the big hammer to one that makes this
> > > work just on x86/x86-64?
> > 
> > That seems reasonable as a temporary measure.
> 
> Applying this to my perf/urgent branch, ack?
>
> - Arnaldo
> 
> commit 57f7077f41104c5499a89803f58b5886ee51555f
> Author: Arnaldo Carvalho de Melo <acme@...hat.com>
> Date:   Mon Feb 10 14:09:48 2014 -0300
> 
>     perf trace: Fix ioctl 'request' beautifier build problems on !(i386 || x86_64) arches
>     
>     Supporting decoding the ioctl 'request' parameter needs more work to
>     properly support more architectures, the current approach doesn't work
>     on at least powerpc and sparc, as reported by Ben Hutchings in
>     http://lkml.kernel.org/r/1391593985.3003.48.camel@deadeye.wl.decadent.org.uk .
>     
>     Work around that by making it to be ifdefed for the architectures known
>     to work with the current, limited approach, i386 and x86_64 till better
>     code is written.
>     
>     Reported-by: Ben Hutchings <ben@...adent.org.uk>
>     Cc: Adrian Hunter <adrian.hunter@...el.com>
>     Cc: David Ahern <dsahern@...il.com>
>     Cc: Frederic Weisbecker <fweisbec@...il.com>
>     Cc: Jiri Olsa <jolsa@...hat.com>
>     Cc: Mike Galbraith <efault@....de>
>     Cc: Namhyung Kim <namhyung@...nel.org>
>     Cc: Paul Mackerras <paulus@...ba.org>
>     Cc: Peter Zijlstra <peterz@...radead.org>
>     Cc: Stephane Eranian <eranian@...gle.com>
[...]

Please add:

Cc: <stable@...r.kernel.org> # 3.13
Fixes: 78645cf3ed32 ("perf trace: Initial beautifier for ioctl's 'cmd' arg")

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)