linux-kernel - Re: [PATCHv2 2/2] arm: Get rid of meminfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52F94BC3.1060307@codeaurora.org>
Date:	Mon, 10 Feb 2014 13:59:31 -0800
From:	Laura Abbott <lauraa@...eaurora.org>
To:	Courtney Cavin <courtney.cavin@...ymobile.com>
CC:	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Andrew Lunn <andrew@...n.ch>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	Jason Cooper <jason@...edaemon.net>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Eric Miao <eric.y.miao@...il.com>,
	Will Deacon <will.deacon@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	Ben Dooks <ben-linux@...ff.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	Daniel Walker <dwalker@...o99.com>,
	David Brown <davidb@...eaurora.org>,
	Catalin Marinas <catalin.marinas@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCHv2 2/2] arm: Get rid of meminfo

On 2/10/2014 9:28 AM, Courtney Cavin wrote:
> On Mon, Feb 10, 2014 at 04:25:34AM +0100, Laura Abbott wrote:
>> On 2/6/2014 6:09 PM, Courtney Cavin wrote:
>>> On Wed, Feb 05, 2014 at 01:02:31AM +0100, Laura Abbott wrote:
>>>> memblock is now fully integrated into the kernel and is the prefered
>>>> method for tracking memory. Rather than reinvent the wheel with
>>>> meminfo, migrate to using memblock directly instead of meminfo as
>>>> an intermediate.
>>>>
>>>> Signed-off-by: Laura Abbott <lauraa@...eaurora.org>
>>> [...]
>>>> diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
>>>> index 0b11c1a..51d814e 100644
>>>> --- a/arch/arm/mach-pxa/spitz.c
>>>> +++ b/arch/arm/mach-pxa/spitz.c
>>>> @@ -32,6 +32,7 @@
>>>>    #include <linux/io.h>
>>>>    #include <linux/module.h>
>>>>    #include <linux/reboot.h>
>>>> +#include <linux/memblock.h>
>>>>
>>>>    #include <asm/setup.h>
>>>>    #include <asm/mach-types.h>
>>>> @@ -971,13 +972,9 @@ static void __init spitz_init(void)
>>>>           spitz_i2c_init();
>>>>    }
>>>>
>>>> -static void __init spitz_fixup(struct tag *tags, char **cmdline,
>>>> -                              struct meminfo *mi)
>>>> +static void __init spitz_fixup(struct tag *tags, char **cmdline)
>>>>    {
>>>> -       sharpsl_save_param();
>>>> -       mi->nr_banks = 1;
>>>> -       mi->bank[0].start = 0xa0000000;
>>>> -       mi->bank[0].size = (64*1024*1024);
>>>> +       memblock_addr(0xa0000000, SZ_64M);
>>>
>>> memblock_add() ?
>> Yes, that was a typo on my part. I'll send out a v3 with collected acks.
>>
>
> So, I also just noticed that you specifically remove the call to
> sharpsl_save_param() here.  I'm presuming that this is also an error, as
> you haven't removed it from any of the other pxa fixups, and it seems
> unrelated to the change.
>
> -Courtney

Clearly not my finest hour at all. Thanks for reviewing.

Laura


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/