linux-kernel - Re: [PATCH 01/14] asmlinkage, kvm: Make kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140210154637.dd58edfcbae273034d34c4df@linux-foundation.org>
Date:	Mon, 10 Feb 2014 15:46:37 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andi Kleen <ak@...ux.intel.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org, gleb@...hat.com,
	pbonzini@...hat.com, kvm@...r.kernel.org
Subject: Re: [PATCH 01/14] asmlinkage, kvm: Make kvm_rebooting visible

On Sat,  8 Feb 2014 08:51:57 +0100 Andi Kleen <ak@...ux.intel.com> wrote:

> kvm_rebooting is referenced from assembler code, thus
> needs to be visible.

So I read the gcc page and looked at the __visible definition but I
still don't really get it.  What goes wrong if the __visible isn't
present on these referenced-from-asm identifiers?

> Cc: gleb@...hat.com
> Cc: pbonzini@...hat.com

Grumble.  Email addresses go into commits with display names and <>. 
At least, 89.3% of them do.  Some sucker has to go through these and
fix them up.  I'd prefer it not be me ;)

>
> ...
>
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -102,7 +102,7 @@ static void kvm_release_pfn_dirty(pfn_t pfn);
>  static void mark_page_dirty_in_slot(struct kvm *kvm,
>  				    struct kvm_memory_slot *memslot, gfn_t gfn);
>  
> -bool kvm_rebooting;
> +__visible bool kvm_rebooting;
>  EXPORT_SYMBOL_GPL(kvm_rebooting);
>  
>  static bool largepages_enabled = true;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/