linux-kernel - Re: [PATCH 2/5] ncpfs: Convert DPRINTK/DDPRINTK to ncp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 09 Feb 2014 16:53:44 -0800
From:	Joe Perches <joe@...ches.com>
To:	Petr Vandrovec <petr@...drovec.name>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] ncpfs: Convert DPRINTK/DDPRINTK to ncp_dbg

On Sun, 2014-02-09 at 14:48 -0800, Joe Perches wrote:
> Use a more current logging style and enable use of dynamic debugging.
[]
> diff --git a/fs/ncpfs/ncp_fs.h b/fs/ncpfs/ncp_fs.h
[]
> +#define ncp_dbg(level, fmt, ...)				\
> +do {								\
> +	if (level >= DEBUG_NCP)					\
> +		pr_debug(fmt, ##__VA_ARGS__);			\
> +} while (0)

Stupid thinko/typo self-nack.  This should be:

	if (DEBUG_NCP >= level)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/