linux-kernel - Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201402101432356252495@163.com>
Date:	Mon, 10 Feb 2014 14:32:36 +0800
From:	"liujunliang_ljl" <liujunliang_ljl@....com>
To:	"Joe Perches" <joe@...ches.com>
Cc:	"davem" <davem@...emloft.net>,
	"horms" <horms@...ge.net.au>,
	"romieu" <romieu@...zoreil.com>,
	"gregkh" <gregkh@...uxfoundation.org>,
	"netdev" <netdev@...r.kernel.org>,
	"linux-usb" <linux-usb@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"sunhecheng" <sunhecheng@....126.com>
Subject: Re: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support

Dear Joe :

		Thanks a lot for your detail checking.


2014-02-10 



liujunliang_ljl 



发件人： Joe Perches 
发送时间： 2014-02-10  13:47:08 
收件人： liujunliang_ljl 
抄送： davem; horms; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng 
主题： Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support 
 
On Mon, 2014-02-10 at 13:33 +0800, liujunliang_ljl@....com wrote:
> diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c
[]
> + netdev_dbg(dev->net, "mac addr : 0x%x:0x%x:0x%x:0x%x:0x%x:0x%x\n",
> +    dev->net->dev_addr[0], dev->net->dev_addr[1],
> +    dev->net->dev_addr[2], dev->net->dev_addr[3],
> +    dev->net->dev_addr[4], dev->net->dev_addr[5]);
mac addresses are assumed to be hex and don't need 0x prefixes.
Also, there's a kernel vsprintf extension "%pM" for mac addresses.
netdev_dbg(dev->net, "mac addr: %pM\n", dev->net->dev_addr);
.