linux-kernel - Re: [PATCH] staging : android : fix checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140210091135.GR26722@mwanda>
Date:	Mon, 10 Feb 2014 12:11:35 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	gregkh@...uxfoundation.org, john.stultz@...aro.org,
	ohaugan@...eaurora.org, romlem@...gle.com,
	devel@...verdev.osuosl.org, konkers@...roid.com,
	linux-kernel@...r.kernel.org, ccross@...roid.com,
	rebecca@...roid.com, prtvar.b@...il.com
Subject: Re: [PATCH] staging : android : fix checkpatch issues

On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote:
> @@ -1376,14 +1376,14 @@ static int ion_debug_heap_show(struct seq_file *s, void *unused)
>  		}
>  	}
>  	mutex_unlock(&dev->buffer_lock);
> -	seq_printf(s, "----------------------------------------------------\n");
> +	seq_puts(s, "----------------------------------------------------\n");
>  	seq_printf(s, "%16.s %16zu\n", "total orphaned",
>  		   total_orphaned_size);

This kind of thing where you put a seq_puts() in the middle of a string
of seq_printf() calls is not good.  We only make checkpatch.pl warn
about it to see if patch submitters are paying attention and to test the
patience of reviewers.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/