linux-kernel - Re: [PATCH v2 1/8] ASoC: da9055: Fix device registration of PMIC and CODEC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140210115109.GC22773@lee--X1>
Date:	Mon, 10 Feb 2014 11:51:09 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v2 1/8] ASoC: da9055: Fix device registration of PMIC and
 CODEC devices

> > > +/*
> > > + * DO NOT change the device Ids. The naming is intentionally specific as both
> > > + * the PMIC and CODEC parts of this chip are instantiated separately as I2C
> > > + * devices (both have configurable I2C addresses, and are to all intents and
> > > + * purposes separate). As a result there are specific DA9055 ids for PMIC
> > > + * and CODEC, which must be different to operate together.
> > > + */
> 
> > I'm not sure this comment is required.
> 
> They are, we've already had the suffixes removed from both PMIC and
> CODEC drivers by people doing code review causing the drivers to fail to
> load for several kernel releases (this should be tagged to stable as a
> result).
> 
> > Most device IDs are named this way.
> 
> Having the suffix on a subdevice would be normal but it's not normal for
> the primary I2C device, usually you can just put the part number in.

Okay, no problem then. Ignore my last.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/