linux-kernel - Re: [PATCH 1/2] regulator: anatop: Add power gating support to digital LDOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140210133254.GE1757@sirena.org.uk>
Date:	Mon, 10 Feb 2014 13:32:54 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Anson Huang <b20788@...escale.com>, kernel@...gutronix.de
Subject: Re: [PATCH 1/2] regulator: anatop: Add power gating support to
 digital LDOs

On Mon, Feb 10, 2014 at 02:27:55PM +0100, Philipp Zabel wrote:

> yes, thanks. I'll fix this. What should happen if the
> regulator_set_voltage_sel_regmap fails? Is it ok to still
> set the cache in this case?

Either way is fine but not updating the cache is probably better - if it
was a physical write we'd not actually be sure if the write made it to
hardware (it could also have written nonsense!) so we can't really
guarantee what the state is after a failed operation.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)