linux-kernel - Re: [PATCH v2] mfd: MAX6650/6651 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140210155628.GA26997@lee--X1>
Date:	Mon, 10 Feb 2014 15:56:28 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	Laszlo Papp <lpapp@....org>,
	Linus Walleij <linus.walleij@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mfd: MAX6650/6651 support

> >> > +#include <linux/device.h>
> >> > +#include <linux/mfd/core.h>
> >> > +#include <linux/module.h>
> >> > +#include <linux/i2c.h>
> >>
> >> Please arrange these alphabetically.
> >
> > Why?
> 
> 1. It makes it easier to avoid adding duplicate includes.
> 2. Code looks more ordered/organized.
> 3. Prevents further clean up patches arranging them so :)

I wouldn't accept any patches doing such worthless things. ;)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/