linux-kernel - Re: [Resend PATCH] staging : ion : Fix some checkpatch warnings and an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Feb 2014 08:33:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	gregkh@...uxfoundation.org, swetland@...gle.com,
	john.stultz@...aro.org, rebecca@...roid.com, ccross@...roid.com,
	ohaugan@...eaurora.org, romlem@...gle.com,
	linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [Resend PATCH] staging : ion : Fix some checkpatch warnings and
 an error

On Mon, 2014-02-10 at 20:25 +0900, Daeseok Youn wrote:

> Warning:
>  - Unnecessary space after function pointer name
>  - quoted string split across lines
> 
> Error:
>  - return is not a function, parentheses are not required

Hi.

checkpatch issuing either an ERROR or WARNING isn't
really relevant to the subject.

This isn't really a resend.  It's a different version
and so the subject should not say "Resend".  Ideally,
you send this with a subject like:

[PATCH V2] staging: ion: Whitespace neatening

and if needed again:

[PATCH V3] staging: ion: Whitespace neatening

etc...

and below:

> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
[]
> @@ -55,7 +55,7 @@ struct ion_device {
>  	struct mutex buffer_lock;
>  	struct rw_semaphore lock;
>  	struct plist_head heaps;
> -	long (*custom_ioctl) (struct ion_client *client, unsigned int cmd,
> +	long (*custom_ioctl)(struct ion_client *client, unsigned int cmd,
>  			      unsigned long arg);

Please realign the arguments to the open parenthesis like:

	long (*custom_ioctl)(struct ion_client *client, unsigned int cmd,
			     unsigned long arg);

> diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h
[]
> @@ -100,18 +100,18 @@ void ion_buffer_destroy(struct ion_buffer *buffer);
>   * map_dma and map_kernel return pointer on success, ERR_PTR on error.
>   */
>  struct ion_heap_ops {
> -	int (*allocate) (struct ion_heap *heap,
> +	int (*allocate)(struct ion_heap *heap,
>  			 struct ion_buffer *buffer, unsigned long len,
>  			 unsigned long align, unsigned long flags);

realignment here too

etc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/