linux-kernel - Re: [tip:perf/core] x86/nmi: Push duration printk() to irq context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52F9021C.1030801@linux.intel.com>
Date:	Mon, 10 Feb 2014 08:45:16 -0800
From:	Dave Hansen <dave.hansen@...ux.intel.com>
To:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	peterz@...radead.org, tglx@...utronix.de, dzickus@...hat.com,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] x86/nmi: Push duration printk() to irq context

On 02/10/2014 05:29 AM, tip-bot for Peter Zijlstra wrote:
> x86/nmi: Push duration printk() to irq context
> 
> Calling printk() from NMI context is bad (TM), so move it to IRQ
> context.

Bad since the I/O device that we're doing it to may be slow and make the
NMI painfully long?

I can see why it might be a bad idea, but I'm unsold that it is
*universally* a bad idea.

> In doing so we slightly change (probably wreck) the debugfs
> nmi_longest_ns thingy, in that it doesn't update to reflect the
> longest, nor does writing to it reset the count.

The reason I coded this up was that NMIs were firing off so fast that
nothing else was getting a chance to run.  With this patch, at least the
printk() would come out and I'd have some idea what was going on.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/