linux-kernel - Re: [PATCH] mfd: omap-usb-tll: allocate correct size for ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140210195421.GB31864@lee--X1>
Date:	Mon, 10 Feb 2014 19:54:21 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	rogerq@...com
Subject: Re: [PATCH] mfd: omap-usb-tll: allocate correct size for ch_clk

> From: Colin Ian King <colin.king@...onical.com>
> 
> ch_clk was erroneously being allocated the incorrect size which
> can be problematic for larger sizes of tll->nch
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/mfd/omap-usb-tll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> index 5ee50f7..532eacab 100644
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -252,7 +252,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
>  		break;
>  	}
>  
> -	tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]),
> +	tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk *) * tll->nch,
>  						GFP_KERNEL);
>  	if (!tll->ch_clk) {
>  		ret = -ENOMEM;

Thanks Colin, patch looks good to me.

Roger, fancy finishing this off with an Acked-by?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/