linux-kernel - Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1392001112.3178.15.camel@joe-AO722>
Date:	Sun, 09 Feb 2014 18:58:32 -0800
From:	Joe Perches <joe@...ches.com>
To:	liujunliang_ljl@....com
Cc:	davem@...emloft.net, horms@...ge.net.au, romieu@...zoreil.com,
	gregkh@...uxfoundation.org, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	sunhecheng@....126.com
Subject: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800
 Device Driver Support

On Fri, 2014-02-07 at 14:42 +0800, liujunliang_ljl@....com wrote:

> +		netdev_dbg(dev->net, "Write IPG,IPG1,IPG2 failed: %d", ret);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after all initializations",
[]
> +	netdev_dbg(dev->net, "Medium Status : 0x%04x after all initializations",
[]
> +		netdev_dbg(dev->net, "Select PHY #1 failed: %d", ret);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after software reset", rx_ctl);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x setting to 0x0000", rx_ctl);
[]
> +	memcpy(data->mac_addr, dev->net->dev_addr, ETH_ALEN);

ether_addr_copy

> +		netdev_err(dev->net, "Failed to power down PHY : %d", ret);
[]
> +		netdev_err(dev->net, "Failed to reset PHY: %d", ret);
[]
> +		netdev_err(dev->net, "Failed to power up PHY: %d", ret);
[]
> +		netdev_err(dev->net, "Failed to reset PHY: %d", ret);
[]
> +			netdev_err(dev->net, "set LINK LED failed : %d", ret);
[]
> +		netdev_dbg(dev->net, "Failed to read MAC address: %d", ret);
[]
> +		netdev_dbg(dev->net, "Select PHY #1 failed: %d", ret);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after software reset", rx_ctl);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x setting to 0x0000", rx_ctl);
[]
> +	netdev_dbg(dev->net, "PHYID=0x%08x", phyid);

Please make sure all of the netdev_<level> uses have a '\n'
line termination.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/