linux-kernel - Re: [PATCH 24/51] x86, hpet: Fix CPU hotplug callback registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Feb 2014 12:29:36 +0530
From:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
To:	ego@...ux.vnet.ibm.com
CC:	paulus@...ba.org, oleg@...hat.com, rusty@...tcorp.com.au,
	peterz@...radead.org, tglx@...utronix.de,
	akpm@...ux-foundation.org, mingo@...nel.org,
	paulmck@...ux.vnet.ibm.com, tj@...nel.org, walken@...gle.com,
	linux@....linux.org.uk, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH 24/51] x86, hpet: Fix CPU hotplug callback registration

On 02/11/2014 12:28 AM, Gautham R Shenoy wrote:
> Hi,
> 
> On Thu, Feb 06, 2014 at 03:39:00AM +0530, Srivatsa S. Bhat wrote:
>> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
>> index da85a8e..199aaae 100644
>> --- a/arch/x86/kernel/hpet.c
>> +++ b/arch/x86/kernel/hpet.c
>> @@ -943,12 +943,14 @@ static __init int hpet_late_init(void)
>>  	if (boot_cpu_has(X86_FEATURE_ARAT))
>>  		return 0;
>>
>> +	cpu_maps_update_begin();
>>  	for_each_online_cpu(cpu) {
>>  		hpet_cpuhp_notify(NULL, CPU_ONLINE, (void *)(long)cpu);
>>  	}
>>
>>  	/* This notifier should be called after workqueue is ready */
>> -	hotcpu_notifier(hpet_cpuhp_notify, -20);
>> +	__hotcpu_notifier(hpet_cpuhp_notify, -20);
> 
> We could #define HPET_CPUHP_PRIO relative to the workqueue priority instead of
> hardcoding this it this way.
> 

Sure, we can do that. Thanks for pointing that out!
 
Regards,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/