linux-kernel - Re: [patch] w1: small type cleanup in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140211211228.GY26722@mwanda>
Date:	Wed, 12 Feb 2014 00:12:28 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	David Fries <David@...es.net>
Cc:	Evgeniy Polyakov <zbr@...emap.net>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] w1: small type cleanup in sysfs

On Tue, Feb 11, 2014 at 10:45:13AM -0600, David Fries wrote:
> Dan,
> 
> I have some other changes in work, how automated is your checkers?
> How much work is it for me to give a github repository and branch and
> find out if I introduced any problems before submitting them?
> 

This is a Smatch thing I'm working on but haven't pushed yet.
Eventually it will be a part of Fengguang Wu's automated kbuild zero
day testing process.

> 
> I didn't get how you could get a less than one after a check for less
> than one from the description or patch until I looked at the rest of
> the source code.  Looks good if the description mentions
> max_slave_count is an int.
> 
> How about wording it,
> 
> On 64 bit systems, a large value for "long tmp" is truncated when
> assigning to "int md->max_slave_count" so we still end up with a value
> less than one despite the "tmp < 1" check.
> 

Sure.  That's clearer.  I have resent it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/