linux-kernel - Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52FA99CA.8070505@kernel.dk>
Date:	Tue, 11 Feb 2014 14:44:42 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Sander Eikelenboom <linux@...elenboom.it>,
	David Vrabel <david.vrabel@...rix.com>
CC:	Roger Pau Monné <roger.pau@...rix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org,
	mrushton@...zon.com, msw@...zon.com, boris.ostrovsky@...cle.com
Subject: Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying
 to register non-static key. the code is fine but needs lockdep annotation.

On 2014-02-11 13:21, Sander Eikelenboom wrote:
>
> Tuesday, February 11, 2014, 7:21:56 PM, you wrote:
>
>> On 11/02/14 18:15, Roger Pau Monné wrote:
>>> On 11/02/14 18:52, David Vrabel wrote:
>>>>
>>> That would mean that unmap_purged_grants would no longer be static and
>>> I should also add a prototype for it in blkback/common.h, which is kind
>>> of ugly IMHO.
>
>> But less ugly than initializing work with a NULL function, IMO.
>
>>> commit 980e72e45454b64ccb7f23b6794a769384e51038
>>> Author: Roger Pau Monne <roger.pau@...rix.com>
>>> Date:   Tue Feb 11 19:04:06 2014 +0100
>>>
>>>      xen-blkback: init persistent_purge_work work_struct
>>>
>>>      Initialize persistent_purge_work work_struct on xen_blkif_alloc (and
>>>      remove the previous initialization done in purge_persistent_gnt). This
>>>      prevents flush_work from complaining even if purge_persistent_gnt has
>>>      not been used.
>>>
>>>      Signed-off-by: Roger Pau Monné <roger.pau@...rix.com>
>
>> Reviewed-by: David Vrabel <david.vrabel@...rix.com>
>
> And a Tested-by: Sander Eikelenboom <linux@...elenboom.it>

Konrad, I was going to ship my current tree today, but looks like we 
need this too.

-- 
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/