linux-kernel - RE: [PATCH 2/2] ASoC: fsl-esai: big-endian support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Feb 2014 07:27:19 +0000
From:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
To:	"guangyu.chen@...escale.com" <guangyu.chen@...escale.com>
CC:	"broonie@...nel.org" <broonie@...nel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.de" <tiwai@...e.de>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] ASoC: fsl-esai: big-endian support



> > +  - big-endian : If this property is absent, the native endian mode will
> > +    be in use as default, or the big endian mode will be in use for all the
> > +    device registers.
> 
> > +
> > +
> 
> Single blank line should be enough here :)
> 

This will be removed.


> > @@ -687,6 +688,10 @@ static int fsl_esai_probe(struct platform_device *pdev)
> >  	esai_priv->pdev = pdev;
> >  	strcpy(esai_priv->name, np->name);
> >
> > +	esai_priv->big_endian = of_property_read_bool(np, "big-endian");
> > +	if (esai_priv->big_endian)
> > +		fsl_esai_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
> > +
> 
> Same comments here. And please wait for Shawn's reply at the other patch
> before you revise this part to V2.
> 

Okey,


Thanks,

--
Best Regards,
Xiubo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/