linux-kernel - Re: [Resend PATCH] staging : ion : Fix some checkpatch warnings and an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Feb 2014 16:20:24 -0800
From:	Joe Perches <joe@...ches.com>
To:	DaeSeok Youn <daeseok.youn@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Brian Swetland <swetland@...gle.com>,
	John Stultz <john.stultz@...aro.org>,
	Rebecca Zavin <rebecca@...roid.com>, ccross@...roid.com,
	ohaugan@...eaurora.org, Rom Lemarchand <romlem@...gle.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [Resend PATCH] staging : ion : Fix some checkpatch warnings and
 an error

On Tue, 2014-02-11 at 09:11 +0900, DaeSeok Youn wrote:
> Hi,

Hello.

> Thanks for review.
> If I send this patch again, i will use a subject as you comment.

Thanks.

> And alignment issue, my patch line seems to be same with your example.

You took out a space from the line with the function pointer
but not from the subsequent lines of the arguments.

> >> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> > []
> >> @@ -55,7 +55,7 @@ struct ion_device {
> >>       struct mutex buffer_lock;
> >>       struct rw_semaphore lock;
> >>       struct plist_head heaps;
> >> -     long (*custom_ioctl) (struct ion_client *client, unsigned int cmd,
> >> +     long (*custom_ioctl)(struct ion_client *client, unsigned int cmd,
> >>                             unsigned long arg);
> >
> > Please realign the arguments to the open parenthesis like:
> >
> >         long (*custom_ioctl)(struct ion_client *client, unsigned int cmd,
> >                              unsigned long arg);

Your patch has:

	long (*custom_ioctl)(struct ion_client *client, unsigned int cmd,
			      unsigned long arg);

it should be:

	long (*custom_ioctl)(struct ion_client *client, unsigned int cmd,
			     unsigned long arg);

with the "unsigned long arg" aligned immediately after
the open parenthesis of the function arguments.

(under the "s" of struct, not the first "t" of struct)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/