linux-kernel - Re: [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52F9F020.6090504@ti.com>
Date:	Tue, 11 Feb 2014 11:40:48 +0200
From:	Roger Quadros <rogerq@...com>
To:	Colin King <colin.king@...onical.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][v2] mfd: omap-usb-tll: fix cppcheck sizeof warning

On 02/11/2014 11:38 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Static analysis from cppcheck issued the following warning:
> 
> [drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation
>   inside sizeof().
> 
> The current size calculation is not obvious and is easy to
> miscomprehend, so re-work the size of the allocation based
> on the size of the struct pointer and quantity to allocate.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/mfd/omap-usb-tll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> index 5ee50f7..532eacab 100644
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -252,7 +252,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
>  		break;
>  	}
>  
> -	tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]),
> +	tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk *) * tll->nch,
>  						GFP_KERNEL);
>  	if (!tll->ch_clk) {
>  		ret = -ENOMEM;
> 

Thanks for the patch Colin.

Acked-by: Roger Quadros <rogerq@...com>

--
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/