linux-kernel - Re: [PATCH v2] mfd: MAX6650/6651 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMwXhNcYpBvMEhcxtvsnByeB7QxO56gjAC+JP2s0tRvmyQiXQ@mail.gmail.com>
Date:	Tue, 11 Feb 2014 10:10:17 +0000
From:	Laszlo Papp <lpapp@....org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v2] mfd: MAX6650/6651 support

>>> [snip]
>>>> +
>>>> +struct max665x_dev {
>>>> +       struct device *dev;
>>>> +       struct mutex iolock;
>>>> +
>>>> +       struct i2c_client *i2c;
>>>> +       struct regmap     *map;
>>>> +
>>>> +       int type;
>>>
>>> Unnecessary extra lines above could be removed.
>>
>> I prefer it that way, but I will remove the two extra lines as you wish.
>
> As I already said, these are just nits and only since you were
> re-spinning the patch,
> I suggested them. Also, since this is a new file being added, it
> avoids further patches
> doing these same things.

Well, it is worse in my opinion because it makes the code more bloated
without separation between units, but I made the requested change
anyway because the feature matters lotta more to me than this styling.
Hope it is OK now?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/