lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Feb 2014 15:53:06 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Paul Bolle <pebolle@...cali.nl> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org, Richard Weinberger <richard@....at>, Martin Walch <walch.martin@....de>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: r8188eu: default to "y" in Kconfig On Tue, Feb 11, 2014 at 01:31:32PM +0100, Paul Bolle wrote: > Two Kconfig entries for this driver default to (uppercase) "Y". But in > Kconfig (lowercase) "y" is a magic symbol. "Y" is an ordinary symbol. > As "Y" is never set these Kconfig symbols will also not be set by > default. > > So use "default y" here, as was clearly intended. > > Signed-off-by: Paul Bolle <pebolle@...cali.nl> > --- > This patch will enable code that used to be disabled. Since this is in > staging, that should be OK. This might also uncover warnings or errors. > I didn't test it, anyhow. > > This patch also deserves a > Reported-by: Martin Walch <walch.martin@....de> > > line, but that apparently requires Martin's permission. > You've pretty much given Martin's secret assistance away already on a public mailing list. Next time just add the Reported-by. :P regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists