linux-kernel - Re: [PATCH 4/4] hugetlb: hugepagesnid=: add 1G huge page support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140211102701.6114576b@redhat.com>
Date:	Tue, 11 Feb 2014 10:27:01 -0500
From:	Luiz Capitulino <lcapitulino@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	mtosatti@...hat.com, mgorman@...e.de, aarcange@...hat.com,
	andi@...stfloor.org, riel@...hat.com
Subject: Re: [PATCH 4/4] hugetlb: hugepagesnid=: add 1G huge page support

On Mon, 10 Feb 2014 15:30:32 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Mon, 10 Feb 2014 12:27:48 -0500 Luiz Capitulino <lcapitulino@...hat.com> wrote:
> 
> > 
> > ...
> >
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -2051,6 +2051,29 @@ void __init hugetlb_add_hstate(unsigned order)
> >  	parsed_hstate = h;
> >  }
> >  
> > +static void __init hugetlb_hstate_alloc_pages_nid(struct hstate *h,
> > +						int nid,
> > +						unsigned long nr_pages)
> > +{
> > +	struct huge_bootmem_page *m;
> > +	unsigned long i;
> > +	void *addr;
> > +
> > +	for (i = 0; i < nr_pages; i++) {
> > +		addr = memblock_virt_alloc_nid_nopanic(
> > +				huge_page_size(h), huge_page_size(h),
> > +				0, BOOTMEM_ALLOC_ACCESSIBLE, nid);
> > +		if (!addr)
> > +			break;
> > +		m = addr;
> > +		BUG_ON((unsigned long)virt_to_phys(m) & (huge_page_size(h) - 1));
> 
> IS_ALIGNED()?
> 
> > +		list_add(&m->list, &huge_boot_pages);
> > +		m->hstate = h;
> > +	}
> > +
> > +	h->max_huge_pages += i;
> > +}
> > +
> >  void __init hugetlb_add_nrpages_nid(unsigned order, unsigned long nid,
> >  				unsigned long nr_pages)
> >  {
> 
> Please cc Yinghai Lu <yinghai@...nel.org> on these patches - he
> understands memblock well and is a strong reviewer.

Will do for v2, with your comments addressed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/