linux-kernel - Re: [PATCH] block: Fix cloning of discard/write same bios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140211154107.GD19057@kernel.dk>
Date:	Tue, 11 Feb 2014 08:41:07 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	"Richard W.M. Jones" <rjones@...hat.com>
Cc:	Kent Overstreet <kmo@...erainc.com>, clm@...com,
	linux-fsdevel@...r.kernel.org, neilb@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: Fix cloning of discard/write same bios

On Tue, Feb 11 2014, Richard W.M. Jones wrote:
> On Mon, Feb 10, 2014 at 05:45:50PM -0800, Kent Overstreet wrote:
> > Immutable biovecs changed the way bio segments are treated in such a way that
> > bio_for_each_segment() cannot now do what we want for discard/write same bios,
> > since bi_size means something completely different for them.
> > 
> > Fortunately discard and write same bios never have more than a single biovec, so
> > bio_for_each_segment() is unnecessary and not terribly meaningful for them, but
> > we still have to special case them in a few places.
> > 
> > Signed-off-by: Kent Overstreet <kmo@...erainc.com>
> 
> Tested-by: Richard W.M. Jones <rjones@...hat.com>
> 
> I have confirmed this fixes the bug described here:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1061339

Thanks, I have applied it for immediate inclusion.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/