linux-kernel - Re: [PATCH] mfd: dbx500/abx500: root out hardcoded IRQ assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140211173933.GW13533@sirena.org.uk>
Date:	Tue, 11 Feb 2014 17:39:33 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: dbx500/abx500: root out hardcoded IRQ assignments

On Tue, Feb 11, 2014 at 11:29:59AM +0100, Linus Walleij wrote:

> I've been ambivalent on how to look up the IRQ resource for the
> AB8500 from the device tree (as it is hanging off the main GIC
> interrupt controller rather than the PRCMU) and eventually ended
> up with this solution. I experimented with modifying mfd-core.c
> to add resources from the device tree, but I didn't like the
> result, it seems MFD cells should get their resources exclusively
> from the parent instantiating the cell, so I ended up with this.

> Maybe Broonie has ideas about this too?

This looks reasonably sensible to me.  The way irqdomains seem to want
you to encapsulate this stuff is that the internal interrupts of the
chip get an irqdomain and then the children get their resources relative
to that, normally using the MFD helpers to map the hwirqs in the domain
to Linux interrupt numbers.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)