linux-kernel - Re: [PATCH 1/2] scsi_sysfs: Implement 'is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140212075743.GA13498@infradead.org>
Date:	Tue, 11 Feb 2014 23:57:43 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Hannes Reinecke <hare@...e.de>
Cc:	James Bottomley <jbottomley@...allels.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] scsi_sysfs: Implement 'is_visible' callback

On Tue, Feb 11, 2014 at 03:34:53PM +0100, Hannes Reinecke wrote:
> Instead of modifying attributes after the device has been created
> we should be using the 'is_visible' callback to avoid races.

Can't say I like the fact that the is_visible function needs is
per-group and not per attribute and thus needs to explicitly check
which attribute we call it for, but that seems to be a design issue in
the driver core and not the patch.

Otherwise looks good with the minor nitpick that it would have looked
cleaner in the patch if you had left the queue_type store function
in the location it previously was.

Reviewed-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/