linux-kernel - Re: [PATCH 2/5] cpuidle/idle: Move the cpuidle_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52FB5061.1000709@linux.vnet.ibm.com>
Date:	Wed, 12 Feb 2014 16:13:45 +0530
From:	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
CC:	mingo@...nel.org, peterz@...radead.org, tglx@...utronix.de,
	rjw@...ysocki.net, nicolas.pitre@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] cpuidle/idle: Move the cpuidle_idle_call function
 to idle.c

Hi Daniel,

On 02/11/2014 08:41 PM, Daniel Lezcano wrote:
> The cpuidle_idle_call does nothing more than calling the three individuals
> function and is no longer used by any arch specific code but only in the
> cpuidle framework code.
> 
> We can move this function into the idle task code to ensure better
> proximity to the scheduler code.

So my understanding of this patchset is that by moving
cpuidle_idle_call() under kernel/sched, we now have a way of calling
into the cpuidle governor and the cpuidle driver with additional
parameters like cpu_load(), idle_stamp etc.. so that we can expect the
governor and driver to take better decisions about entry and exit into
idle states. Is this the advantage we hope to begin with?

Thanks

Regards
Preeti U Murthy
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> Acked-by: Nicolas Pitre <nicolas.pitre@...aro.org>
> ---

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/