linux-kernel - Re: [PATCH v2 2/2] of/gpio: Automatically decode OF_GPIO_OPEN_DRAIN and OF_GPIO_OPEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFu+WekUizRz6G=Rwfbd8Tc1vY6DqV=JDeM_bg4GQ50xZNQ@mail.gmail.com>
Date:	Wed, 12 Feb 2014 11:21:17 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	David Daney <ddaney.cavm@...il.com>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH v2 2/2] of/gpio: Automatically decode OF_GPIO_OPEN_DRAIN
 and OF_GPIO_OPEN_SOURCE flags in gpiolib.

On Wed, Feb 12, 2014 at 4:50 AM, David Daney <ddaney.cavm@...il.com> wrote:
> From: David Daney <david.daney@...ium.com>
>
> Just as gpiod_get() automatically interprets the OF_GPIO_ACTIVE_LOW
> flag from the device tree, add handling for OF_GPIO_OPEN_DRAIN and
> OF_GPIO_OPEN_SOURCE.
>
> This keeps the details of handling open-drain GPIOs in the core GPIO
> code, and out of the individual drivers.
>
> Signed-off-by: David Daney <david.daney@...ium.com>
> ---
>  drivers/gpio/gpiolib.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 50c4922..7f596d0 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -2307,6 +2307,12 @@ static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
>         if (of_flags & OF_GPIO_ACTIVE_LOW)
>                 *flags |= GPIO_ACTIVE_LOW;
>
> +       if (of_flags & OF_GPIO_OPEN_DRAIN)
> +               *flags |= GPIO_OPEN_DRAIN;
> +
> +       if (of_flags & OF_GPIO_OPEN_SOURCE)
> +               *flags |= GPIO_OPEN_SOURCE;
> +
>         return desc;
>  }

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>

Thanks for taking the time to do this!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/