linux-kernel - Re: [alsa-devel] [PATCH] ASoC: dapm: Add locking to snd_soc_dapm_xxxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5heh387ekm.wl%tiwai@suse.de>
Date:	Wed, 12 Feb 2014 12:31:05 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	broonie@...nel.org, alsa-devel@...a-project.org,
	patches@...nsource.wolfsonmicro.com, dmitry.torokhov@...il.com,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	cw00.choi@...sung.com, myungjoo.ham@...sung.com
Subject: Re: [alsa-devel] [PATCH] ASoC: dapm: Add locking to	snd_soc_dapm_xxxx_pin functions

At Wed, 12 Feb 2014 11:26:40 +0000,
Charles Keepax wrote:
> 
> On Mon, Feb 10, 2014 at 02:05:26PM +0100, Takashi Iwai wrote:
> > At Mon, 10 Feb 2014 11:05:36 +0000,
> > Charles Keepax wrote:
> > > 
> <snip>
> > > 
> > Actually, this fixes also the double-lock in snd_soc_dapm_sync() call
> > in the line below the above.  snd_soc_dapm_sync() itself takes
> > mutex_lock_nested().
> 
> Yeah spotted that as I was going through will do this in a
> seperate patch if this one doesn't go in.

As the deadlock seems present since long time ago, it'd be better to
have a fix patch (for stable kernels), then move to the new scheme, if
any.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/