linux-kernel - Re: [PATCH v2] NFSv4.1: new layout stateid can not be overwrite by one out of date

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Feb 2014 07:34:38 -0500
From:	Trond Myklebust <trond.myklebust@...marydata.com>
To:	shaobingqing <shaobingqing@...tor.com.cn>
Cc:	linuxnfs <linux-nfs@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] NFSv4.1: new layout stateid can not be overwrite by one out of date


On Feb 12, 2014, at 5:06, shaobingqing <shaobingqing@...tor.com.cn> wrote:

> If initiate_file_draining returned NFS4ERR_DELAY, all the lsegs of
> a file might be released before the retrying cb_layout request arriving
> at the client. In this situation, layoutget request of the file will
> use open stateid to obtain a new layout stateid. And if the retrying
> cb_layout request arrived at the client after the layoutget reply,
> new layout stateid would be overwrite by one out of date.
> 
> Signed-off-by: shaobingqing <shaobingqing@...tor.com.cn>
> ---
> fs/nfs/callback.h      |    5 +++++
> fs/nfs/callback_proc.c |   24 ++++++++++++++++++++++++
> fs/nfs/inode.c         |    1 +
> include/linux/nfs_fs.h |    1 +
> 4 files changed, 31 insertions(+), 0 deletions(-)
> 
<snip>
> diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
> index 3ea4cde..ba47870 100644
> --- a/include/linux/nfs_fs.h
> +++ b/include/linux/nfs_fs.h
> @@ -181,6 +181,7 @@ struct nfs_inode {
> 	struct nfs4_cached_acl	*nfs4_acl;
>         /* NFSv4 state */
> 	struct list_head	open_states;
> +	struct list_head	cb_stale_state_list;
> 	struct nfs_delegation __rcu *delegation;
> 	fmode_t			 delegation_state;
> 	struct rw_semaphore	rwsem;

No. We are definitely not adding new fields to the inode in order to track old layout stateids.
_________________________________
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@...marydata.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/