linux-kernel - Re: [Xen-devel] [PATCH v2 2/4] xen-blkback: fix memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <52FB7A46.7020801@amazon.de>
Date:	Wed, 12 Feb 2014 14:42:30 +0100
From:	"Egger, Christoph" <chegger@...zon.de>
To:	Matthew Rushton <mrushton7@...oo.com>,
	Roger Pau Monne ‎‎ 
	<roger.pau@...rix.com>
CC:	Ian Campbell ‎ <Ian.Campbell@...rix.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mrushton@...zon.com" <mrushton@...zon.com>,
	David Vrabel ‎‎‎ 
	<david.vrabel@...rix.com>, "msw@...zon.com" <msw@...zon.com>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	Boris Ostrovsky ‎ 
	<boris.ostrovsky@...cle.com>,
	"aliguori@...zon.com" <aliguori@...zon.com>
Subject: Re: [Xen-devel] [PATCH v2 2/4] xen-blkback: fix memory leaks

On 07.02.14 04:15, Matthew Rushton wrote:
> On 04/02/14 10:26, Roger Pau Monne wrote:
>> I've at least identified two possible memory leaks in blkback, both
>> related to the shutdown path of a VBD:
>> 
>> - blkback doesn't wait for any pending purge work to finish before
>>   cleaning the list of free_pages. The purge work will call
>>   put_free_pages and thus we might end up with pages being added to
>>   the free_pages list after we have emptied it. Fix this by making
>>   sure there's no pending purge work before exiting
>>   xen_blkif_schedule, and moving the free_page cleanup code to
>>   xen_blkif_free.
>> - blkback doesn't wait for pending requests to end before cleaning
>>   persistent grants and the list of free_pages. Again this can add
>>   pages to the free_pages list or persistent grants to the
>>   persistent_gnts red-black tree. Fixed by moving the persistent
>>   grants and free_pages cleanup code to xen_blkif_free.
>> 
>> Also, add some checks in xen_blkif_free to make sure we are cleaning
>> everything.
> 
> Tested-by: Matt Rushton <mrushton@...zon.com>
> Reviewed-by: Matt Rushton <mrushton@...zon.com>

Tested-by: Christoph Egger <chegger@...zon.de>
Reviewed-by: Christoph Egger <chegger@...zon.de>

Christoph

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/