linux-kernel - Re: [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Feb 2014 12:16:01 +0900
From:	SeongJae Park <sj38.park@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, Brian Swetland <swetland@...gle.com>,
	arve@...roid.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY

On Wed, Feb 12, 2014 at 5:22 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Sat, Feb 08, 2014 at 11:59:41AM +0900, SeongJae Park wrote:
>> Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
>> anywhere.
>
>>
>> Signed-off-by: SeongJae Park <sj38.park@...il.com>
>> ---
>>  drivers/staging/android/binder.h | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
>> index c4c1ed6..6d08e61 100644
>> --- a/drivers/staging/android/binder.h
>> +++ b/drivers/staging/android/binder.h
>> @@ -87,10 +87,9 @@ struct binder_version {
>>  #define BINDER_WRITE_READ            _IOWR('b', 1, struct binder_write_read)
>>  #define BINDER_SET_IDLE_TIMEOUT              _IOW('b', 3, __s64)
>>  #define BINDER_SET_MAX_THREADS               _IOW('b', 5, __u32)
>> -#define BINDER_SET_IDLE_PRIORITY     _IOW('b', 6, __s32)
>> -#define BINDER_SET_CONTEXT_MGR               _IOW('b', 7, __s32)
>> -#define BINDER_THREAD_EXIT           _IOW('b', 8, __s32)
>> -#define BINDER_VERSION                       _IOWR('b', 9, struct binder_version)
>> +#define BINDER_SET_CONTEXT_MGR               _IOW('b', 6, __s32)
>> +#define BINDER_THREAD_EXIT           _IOW('b', 7, __s32)
>> +#define BINDER_VERSION                       _IOWR('b', 8, struct binder_version)
>
> And you just broke all userspace code that uses this interface :(
>
> Please be more careful, and test your patches properly.

Definitely my fault... Sorry.
I will be more careful and will not do such mistake again.

>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/