lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Feb 2014 10:11:19 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Rob Herring <robherring2@...il.com> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Olof Johansson <olof@...om.net>, Rob Herring <robh@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, "cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org> Subject: Re: [PATCH v2] cpufreq: cpu0: drop selecting of THERMAL and THERMAL_CPU On 12 February 2014 00:03, Rob Herring <robherring2@...il.com> wrote: > From: Rob Herring <robh@...nel.org> > > The addition of THERMAL and THERMAL_CPU selections causes a kconfig > warning on highbank platforms: > > warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has > unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && > REGULATOR && OF && THERMAL && CPU_THERMAL) > > The cpufreq-cpu0 driver does not require thermal zone support to > function as highbank does not need these, so drop selecting of THERMAL > and CPU_THERMAL. > > Reported-by: Olof Johansson <olof@...om.net> > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net> > Cc: Viresh Kumar <viresh.kumar@...aro.org> > Cc: cpufreq@...r.kernel.org > Signed-off-by: Rob Herring <robh@...nel.org> > --- > v2: > - just drop selecting THERMAL and THERMAL_CPU instead of a new kconfig > option > > Dropping REGULATOR doesn't build w/o some empty regulator functions, so > that's 3.15 material. > > Rob > > drivers/cpufreq/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 4b029c0..d100926 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE > > config GENERIC_CPUFREQ_CPU0 > tristate "Generic CPU0 cpufreq driver" > - depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL > + depends on HAVE_CLK && REGULATOR && OF > select PM_OPP > help > This adds a generic cpufreq driver for CPU0 frequency management. Acked-by: Viresh Kumar <viresh.kumar@...aro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists