linux-kernel - Re: [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140213070538.GA11245@verge.net.au>
Date:	Thu, 13 Feb 2014 16:05:38 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Andi Kleen <ak@...ux.intel.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Wensong Zhang <wensong@...ux-vs.org>,
	Patrick McHardy <kaber@...sh.net>, lvs-devel@...r.kernel.org
Subject: Re: [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs
 genl_ops

On Sat, Feb 08, 2014 at 08:57:01AM +0100, Andi Kleen wrote:
> const __read_mostly does not make any sense, because const
> data is already read-only. Remove the __read_mostly
> for the ipvs genl_ops. This avoids a LTO
> section conflict compile problem.

Thanks Andi, applied to ipvs-next.

> Cc: Simon Horman <horms@...ge.net.au>
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: lvs-devel@...r.kernel.org
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index 35be035..2a68a38 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -3580,7 +3580,7 @@ out:
>  }
>  
>  
> -static const struct genl_ops ip_vs_genl_ops[] __read_mostly = {
> +static const struct genl_ops ip_vs_genl_ops[] = {
>  	{
>  		.cmd	= IPVS_CMD_NEW_SERVICE,
>  		.flags	= GENL_ADMIN_PERM,
> -- 
> 1.8.5.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/