linux-kernel - Re: [PATCH] blackfin: bf537: fix typo "CONFIG_SND_SOC_ADV80X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1392284459.30853.17.camel@x220>
Date:	Thu, 13 Feb 2014 10:40:59 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Steven Miao <realmz6@...il.com>
Cc:	adi-buildroot-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blackfin: bf537: fix typo "CONFIG_SND_SOC_ADV80X_MODULE"

[Replaced previous maintainer and list with current maintainer and
list.]

On Fri, 2013-03-08 at 13:06 +0100, Paul Bolle wrote:
> There's a (rather subtle) typo in "CONFIG_SND_SOC_ADV80X_MODULE". Fix it
> once and for all by using IS_ENABLED(), which is designed to avoid
> issues like this.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Has someone ever looked at this trivial patch? The typo is still not
fixed in v3.14-rc2.

> 0) Untested! And this needs build- and runtime testing, especially for
> the MODULE case!
> 
> 1) There are many lines that might be converted to IS_ENABLED() in this
> file. I'm not sure if and how that should be done.
> 
>  arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 95114ed..1872d15 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -985,7 +985,7 @@ static struct spi_board_info bfin_spi_board_info[] __initdata = {
>  	},
>  #endif
>  
> -#if defined(CONFIG_SND_SOC_ADAV80X) || defined(CONFIG_SND_SOC_ADV80X_MODULE)
> +#if IS_ENABLED(CONFIG_SND_SOC_ADAV80X)
>  	{
>  		.modalias = "adav801",
>  		.max_speed_hz = 3125000,     /* max spi clock (SCK) speed in HZ */


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/