linux-kernel - Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <002301cf2855$bb121790$313646b0$%han@samsung.com>
Date:	Thu, 13 Feb 2014 09:51:29 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Pavel Machek' <pavel@....cz>, 'Jenny Tc' <jenny.tc@...el.com>
Cc:	linux-kernel@...r.kernel.org,
	'Dmitry Eremin-Solenikov' <dbaryshkov@...il.com>,
	'Anton Vorontsov' <cbouatmailru@...il.com>,
	'Anton Vorontsov' <anton.vorontsov@...aro.org>,
	'Kim Milo' <Milo.Kim@...com>,
	'Lee Jones' <lee.jones@...aro.org>,
	'Chanwoo Choi' <cw00.choi@...sung.com>,
	'Sachin Kamat' <sachin.kamat@...aro.org>,
	'Lars-Peter Clausen' <lars@...afoo.de>,
	'Pali Rohár' <pali.rohar@...il.com>,
	'Rhyland Klein' <rklein@...dia.com>,
	"'Rafael J. Wysocki'" <rjw@...ysocki.net>,
	'David Woodhouse' <dwmw2@...radead.org>,
	'Tony Lindgren' <tony@...mide.com>,
	'Russell King' <linux@....linux.org.uk>,
	'Sebastian Reichel' <sre@...g0.de>, aaro.koskinen@....fi,
	'Pallala Ramakrishna' <ramakrishna.pallala@...el.com>,
	freemangordon@....bg, linux-omap@...r.kernel.org,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

On Wednesday, February 12, 2014 8:00 PM, Pavel Machek wrote:
> On Wed 2014-02-05 13:44:58, Jenny Tc wrote:
> > On Tue, Feb 04, 2014 at 12:36:30PM +0100, Pavel Machek wrote:
> > > > +struct psy_charger_context {
> > > > +	bool is_usb_cable_evt_reg;
> > > > +	int psyc_cnt;
> > > > +	int batt_status;
> > > > +	/*cache battery and charger properties */
> > >
> > > Comment coding style. Please run you patches through checkpatch.
> >
> > checkpatch doesn't throw any error/warning. /* ... */ not allowed for single line
> > comments? (will fix missing space after /*)
> 
> I meant the space after /*. Maybe checkpatch does not report anything
> here, but I guess there are other places where it will comment :-).

Yes, right.

+	/*cache battery and charger properties */
           ^
'one space' is necessary between '/*' and 'cache'.
This can be fixed as below.
+	/* cache battery and charger properties */

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/