linux-kernel - Re: [PATCH 05/17] lto: Handle LTO common symbols in module loader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zjlxf8fn.fsf@rustcorp.com.au>
Date:	Wed, 12 Feb 2014 11:34:12 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org
Cc:	linux-kbuild@...r.kernel.org, x86@...nel.org,
	Joe Mario <jmario@...hat.com>, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 05/17] lto: Handle LTO common symbols in module loader

Andi Kleen <ak@...ux.intel.com> writes:
> From: Joe Mario <jmario@...hat.com>
>
> Here is the workaround I made for having the kernel not reject modules
> built with -flto.  The clean solution would be to get the compiler to not
> emit the symbol.  Or if it has to emit the symbol, then emit it as
> initialized data but put it into a comdat/linkonce section.
>
> Minor tweaks by AK over Joe's patch.

Patch is fine, but what's with the comment?

>  		switch (sym[i].st_shndx) {
>  		case SHN_COMMON:
> +			/* Ignore common symbols */
> +			if (!strncmp(name, "__gnu_lto", 9))
> +				break;
> +

You mean, "/* Ignore symbols from -flto */"?

Other than that, I'm happy for this to go via some other tree:

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/